Skip to content

feat: port tsconfck (find tsconfig files) #854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

feat: port tsconfck (find tsconfig files) #854

wants to merge 2 commits into from
+1,162 −75

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Nov 19, 2025 •
edited
Loading

Adds Resolver::find_tsconfig.

    /// Finds the `tsconfig` to which this `path` belongs.
    ///
    /// Algorithm:
    ///
    /// 1. Search for `tsconfig.json` in ancestor directories.
    /// 2. If the path is not included in this `tsconfig.json` through the `files`, `include`, or `exclude` fields:
    ///    2.1. Search through project references until a referenced `tsconfig` includes this file.
    ///    2.2. If none of the references include this path, return the `tsconfig.json` found in step 1.
    ///
    /// # Errors
    ///
    /// * Returns an error if the tsconfig is invalid, including any extended or referenced tsconfigs.
  • tracing
  • test windows
  • add benchmark
  • add cache

@graphite-app
Copy link

graphite-app bot commented Nov 19, 2025

How to use the Graphite Merge Queue

Add the label merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@codecov
Copy link

codecov bot commented Nov 19, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 97.31544% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.14%. Comparing base (cfa2279) to head (a0ff198).

Files with missing lines Patch % Lines
src/tsconfig.rs 97.67% 2 Missing ⚠️
src/tsconfig_resolver.rs 96.29% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #854      +/-   ##
==========================================
+ Coverage   94.00%   94.14%   +0.14%     
==========================================
  Files          17       17              
  Lines        2984     3092     +108     
==========================================
+ Hits         2805     2911     +106     
- Misses        179      181       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 19, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #854 will degrade performances by 6.32%

Comparing 11-18-feat_port_tsconfck (a0ff198) with main (cfa2279)

Summary

❌ 1 regression
✅ 10 untouched
🆕 1 new
⏩ 5 skipped1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 resolver_memory[find tsconfig] N/A 15.4 µs N/A
❌ resolver_real[multi-thread] 478.1 µs 510.3 µs -6.32%

Footnotes

  1. 5 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@Boshen Boshen force-pushed the 11-18-feat_port_tsconfck branch 8 times, most recently from efffbb8 to e694af3 Compare November 21, 2025 16:55
@Boshen Boshen force-pushed the 11-18-feat_port_tsconfck branch from e694af3 to a289067 Compare November 21, 2025 16:57
@Boshen Boshen force-pushed the 11-18-feat_port_tsconfck branch from 367c6e8 to a0ff198 Compare November 22, 2025 08:59
@Boshen Boshen requested a review from shulaoda November 22, 2025 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shulaoda shulaoda Awaiting requested review from shulaoda

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Boshen